[PowerPages][vscode.dev] Showing Content Snippets Not Having Language Record #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eters in portal schema
priyanshu92
approved these changes
Dec 20, 2024
Upon reviewing the webpage creation on PPMA, I found that the webpage language is a mandatory field, unlike the content snippet. Therefore, our current implementation should suffice. |
sanxsth
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to handle cases where language codes are null for content snippets and updates to query parameters in portal schemas. The main changes involve error handling, default language code assignment, and query parameter adjustments.
Error handling and default language code assignment:
src/web/client/dal/remoteFetchProvider.ts: Modified thecreateContentFilesfunction to handle cases where the language code is null for content snippets by assigning a default language code.src/web/client/utilities/commonUtil.ts: Updated theGetFileNameWithExtensionfunction to handle cases where the language code is not provided for content snippets by using a default language code.Query parameter adjustments:
src/web/client/schema/portalSchema.ts: Updated the_multiFileFetchQueryParametersinportal_schema_V1to remove the condition checking for non-null language ID values.src/web/client/schema/portalSchema.ts: Updated the_multiFileFetchQueryParametersinportal_schema_V2to remove the condition checking for non-null language ID values.Additional import:
src/web/client/utilities/commonUtil.ts: Added an import forConstantsto use the default language code.